Conversation
steffyP
reviewed
Feb 14, 2024
Contributor
steffyP
left a comment
There was a problem hiding this comment.
Nice sample @HarshCasper! 🚀
I verified that the sample is working, when following the README or executing the script 👍
As someone who hasn't experience with prisma, I have some questions/comments:
- it would be nice to add a link and/or some general information about prisma in the README
- Are the files in
prisma/migrationsrequired to run the sample? I witnessed that new files are created when I run the sample, so I wonder if these are artifacts from a specific run? - When I run the script, I still had to install another lib. I was asked during execution if I want to install, so I guess it's fine. But I wonder if we could install it beforehand as well?
Your database is now in sync with your schema. ✔ Generated Prisma Client (4.16.2 | library) to ./node_modules/@prisma/client in 128ms ┌─────────────────────────────────────────────────────────┐ │ Update available 4.16.2 -> 5.9.1 │ │ │ │ This is a major update - please follow the guide at │ │ https://pris.ly/d/major-version-upgrade │ │ │ │ Run the following to update │ │ npm i --save-dev prisma@latest │ │ npm i @prisma/client@latest │ └─────────────────────────────────────────────────────────┘ Need to install the following packages: generate@0.14.0 Ok to proceed? (y) y - For the creation of the database you currently do not set the MasterUsername and MasterUserPassword, and instead rely on LocalStack defaults. This is actually not in parity with AWS, which will deny the request if those parameters are not set. We could leave it that way, but be aware it may lead to errors in the future when we improve parity.
- Anyhow, it would be great to mention the (default) values for username + password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.